----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151528 -----------------------------------------------------------
Nice Test! src/tests/api_tests.cpp (line 1407) <https://reviews.apache.org/r/52516/#comment219955> s/that/that a src/tests/api_tests.cpp (lines 1416 - 1417) <https://reviews.apache.org/r/52516/#comment219961> hmm, this does not align with the expectations on L1452 i.e., we check for 0 frameworks/agents? Also, we don't seem to be waiting on any offers either. Copy/Paste error? :-) src/tests/api_tests.cpp (lines 1458 - 1459) <https://reviews.apache.org/r/52516/#comment219963> Do you need this? Why can't we just wait on the `event` from the decoder. src/tests/api_tests.cpp (line 1485) <https://reviews.apache.org/r/52516/#comment219964> Nit: s/so/so that src/tests/api_tests.cpp (line 1497) <https://reviews.apache.org/r/52516/#comment219965> This needs to change to just compare for `AgentID`. - Anand Mazumdar On Oct. 5, 2016, 3:30 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52516/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 3:30 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-6102 > https://issues.apache.org/jira/browse/MESOS-6102 > > > Repository: mesos > > > Description > ------- > > Add test for `AGENT_ADDED` and `AGENT_REMOVED` events. > > > Diffs > ----- > > src/tests/api_tests.cpp 7b0ad3c18a38b5ec859a79d09f5707f6958960fb > > Diff: https://reviews.apache.org/r/52516/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
