----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151679 -----------------------------------------------------------
Fix it, then Ship it! src/tests/api_tests.cpp (lines 1416 - 1417) <https://reviews.apache.org/r/52516/#comment220121> hmm, this comment is slightly misleading i.e., we are not creating the event stream after seeing the first offer? It's fine to kill this comment. It's pretty self explanatory that upon starting a master we expect a clean state. src/tests/api_tests.cpp (line 1496) <https://reviews.apache.org/r/52516/#comment220122> Nit: Kill this newline? - Anand Mazumdar On Oct. 5, 2016, 11:48 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52516/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 11:48 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-6102 > https://issues.apache.org/jira/browse/MESOS-6102 > > > Repository: mesos > > > Description > ------- > > Add test for `AGENT_ADDED` and `AGENT_REMOVED` events. > > > Diffs > ----- > > src/tests/api_tests.cpp 7b0ad3c18a38b5ec859a79d09f5707f6958960fb > > Diff: https://reviews.apache.org/r/52516/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
