> On Oct. 5, 2016, 1:02 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1313-1318 > > <https://reviews.apache.org/r/51027/diff/9/?file=1522284#file1522284line1313> > > > > The intention of making allocate asynchronous and returning a Future is > > that the caller could tell when the asynchronous allocation completes and > > could set up a continuation based on this. > > > > As it stands this function just returns Nothing always? Seems it should > > return to the caller once the caller's requested allocation completes. > > Guangya Liu wrote: > Here we want to enqueue only one `allocate(slaves)` request and then > update the `allocationCandidates` for other event trigger allocation requests > before the `allocate(slaves)` request was processed, after the > `allocate(slaves)` request was processed, another `allocate(slaves)` request > will be enqueued again, so seems we do not need to wait till the allocation > completes, but just check the allocation status for each `allocate(slaves)` > request, comments?
By "return to the caller once the allocation completes" I mean "return a Future that is satisfied once the allocation completes". - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151436 ----------------------------------------------------------- On Oct. 4, 2016, 11:31 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51027/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 11:31 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus > Ma, and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Triggered allocations dispatch allocate() only > if there is no pending allocation in the queue. > - Allocation candidates are accumulated and only > cleared when enqueued allocations are processed. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > c8f9492ee1b69e125a1e841116d22a578a9b524e > > Diff: https://reviews.apache.org/r/51027/diff/ > > > Testing > ------- > > make check > > note: check without filters depends on https://reviews.apache.org/r/51028 and > https://reviews.apache.org/r/52534 > > > Thanks, > > Jacob Janco > >
