----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review151822 -----------------------------------------------------------
Given how similar the code in the new example framework is to the existing persistent volumes framework, I think it could make sense to add shared volume features to the existing framework, which could be enabled/disabled via command-line flags. Especially since you add some nice new DESTROY logic in the new framework; it would be great to have that change in the existing one, and avoid duplicating a lot of code. What do you think? - Greg Mann On Sept. 28, 2016, 12:15 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45962/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 12:15 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > Added a persistent volume test framework for shared volumes. > > > Diffs > ----- > > src/Makefile.am fba488f9d676851dd046a8b8c7dd175b3c0d9ef0 > src/examples/persistent_shared_volume_framework.cpp PRE-CREATION > src/tests/examples_tests.cpp 52fac33733cc86dd718c7836c5031999f1597a5c > src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/45962/diff/ > > > Testing > ------- > > New test framework for shared resources added. > Tests successful. > > > Thanks, > > Anindya Sinha > >
