----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/#review151952 -----------------------------------------------------------
Patch looks great! Reviews applied: [52671] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 10, 2016, 12:01 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52671/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 12:01 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6344 > https://issues.apache.org/jira/browse/MESOS-6344 > > > Repository: mesos > > > Description > ------- > > The `--network_cni_plugins_dir` was initially designed to take in a > single directory where all the CNI plugins were expected to be > present. This however is limiting since the operator will have to > ensure that all 3rd party plugins are installed in the same location > which a very hard constraint. > > To make things simpler we are therefore converting the > `--network_cni_plugins_dir` from a single directory into a search > path. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1b22b28825e8160f659c3cbac37cc576f01666d5 > > Diff: https://reviews.apache.org/r/52671/diff/ > > > Testing > ------- > > make, make check and sudo ./bin/mesos-tests.sh --gtest_filter=Cni* > > Also ran a single node cluster and tested the flags by moving the bridge > plugin from directory to another. > > > Thanks, > > Avinash sridharan > >
