-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52671/#review152629
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 145)
<https://reviews.apache.org/r/52671/#comment221724>

    insert a line above.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 149)
<https://reviews.apache.org/r/52671/#comment221721>

    `if (plugin.isNone())`



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 155 - 166)
<https://reviews.apache.org/r/52671/#comment221722>

    Do you still need this? os::which already did the check for you.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 170)
<https://reviews.apache.org/r/52671/#comment221723>

    insert a line above



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 174)
<https://reviews.apache.org/r/52671/#comment221725>

    Ditto.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 180 - 191)
<https://reviews.apache.org/r/52671/#comment221726>

    Ditto.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1160)
<https://reviews.apache.org/r/52671/#comment221727>

    Ditto.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1487)
<https://reviews.apache.org/r/52671/#comment221728>

    Ditto.


- Jie Yu


On Oct. 12, 2016, 5:49 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52671/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 5:49 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6344
>     https://issues.apache.org/jira/browse/MESOS-6344
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `--network_cni_plugins_dir` was initially designed to take in a
> single directory where all the CNI plugins were expected to be
> present. This however is limiting since the operator will have to
> ensure that all 3rd party plugins are installed in the same location
> which a very hard constraint.
> 
> To make things simpler we are therefore converting the
> `--network_cni_plugins_dir` from a single directory into a search
> path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1b22b28825e8160f659c3cbac37cc576f01666d5 
>   src/slave/flags.cpp 491d10f6a8a7ea8adbfe0a09f5fce79943bccfac 
> 
> Diff: https://reviews.apache.org/r/52671/diff/
> 
> 
> Testing
> -------
> 
> make, make check and sudo ./bin/mesos-tests.sh --gtest_filter=Cni*
> 
> Also ran a single node cluster and tested the flags by moving the bridge 
> plugin from directory to another.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to