----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52667/#review152089 -----------------------------------------------------------
src/tests/mesos.hpp (lines 449 - 461) <https://reviews.apache.org/r/52667/#comment220821> Why not enhance the existing `createCommandInfo()` helper method? - Anand Mazumdar On Oct. 11, 2016, 1:14 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52667/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 1:14 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos > > > Description > ------- > > We keep 'shell' as a parameter with a default value as 'false'. It > is redundant for now, but still keep it as we don't want to create > a CommandInfo implicitly. > > > Diffs > ----- > > src/tests/mesos.hpp 5e15f5164cddebd60bb6d9856ae63ad357643cb2 > > Diff: https://reviews.apache.org/r/52667/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
