-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50123/#review152273
-----------------------------------------------------------
I think that for `NvidiaGpuAllocator`, we can add `#ifdef` as following to fix
the build error for mac.
```
class NvidiaGpuAllocator
{
#ifdef __linux__
...
#endif
}
```
src/slave/containerizer/docker.cpp (lines 173 - 175)
<https://reviews.apache.org/r/50123/#comment221208>
```
#ifdef __linux__
if (nvidia.isSome()) {
allocator = nvidia->allocator;
}
#endif
```
src/tests/mock_docker.hpp (line 40)
<https://reviews.apache.org/r/50123/#comment221210>
include `components.hpp` is good enough.
- Guangya Liu
On 十月 11, 2016, 8:16 a.m., Yubo Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50123/
> -----------------------------------------------------------
>
> (Updated 十月 11, 2016, 8:16 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
>
>
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This added 'NvidiaGpuAllocator' to docker containerizer process so that
> docker containerizer process is ready to use it to allocate GPUs to task
> with 'gpus' resource.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d
> src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982
> src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8
> src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c
>
> Diff: https://reviews.apache.org/r/50123/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yubo Li
>
>
