----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review153020 -----------------------------------------------------------
src/slave/containerizer/docker.hpp (line 76) <https://reviews.apache.org/r/50123/#comment222238> Had some discussion offline with Kevin, it is better to use `NvidiaComponents` as a parameter here as it can also enable us to handle `NvidiaVolume` easily in future, this can also enable us use less `#ifdef __linux__` in docker.cpp. - Guangya Liu On 十月 14, 2016, 9:55 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated 十月 14, 2016, 9:55 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer process so that > docker containerizer process is ready to use it to allocate GPUs to task > with 'gpus' resource. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > src/slave/containerizer/mesos/isolators/gpu/allocator.hpp > b2eabfebef99ccebef427d144bb816adc0175ecf > src/slave/containerizer/mesos/isolators/gpu/components.hpp > 82fca5de07c28720f102a02a77563e325e98e066 > src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 > src/tests/mock_docker.cpp 6a0e613bde6889864a37ffd7ec0b454e5fe4df1c > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
