> On Oct. 12, 2016, 7:43 a.m., Jie Yu wrote: > > src/cli/execute.cpp, line 298 > > <https://reviews.apache.org/r/52741/diff/1/?file=1530575#file1530575line298> > > > > Why string? Can this be `Option<CapabilityInfo>`?
This requires I/O support for `v1::CapabilityInfo`. I added these in the preceeding rr https://reviews.apache.org/r/52780/; could you help me get this one is as well? > On Oct. 12, 2016, 7:43 a.m., Jie Yu wrote: > > src/cli/execute.cpp, lines 1064-1084 > > <https://reviews.apache.org/r/52741/diff/1/?file=1530575#file1530575line1064> > > > > Why this is not part of `getContainerInfo`? I added this to `getContainerInfo`, but left a modified version of the consistency check in `main`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/#review152272 ----------------------------------------------------------- On Oct. 12, 2016, 2:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52741/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2016, 2:49 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5303 > https://issues.apache.org/jira/browse/MESOS-5303 > > > Repository: mesos > > > Description > ------- > > This change introduces a flags `capabilities` to mesos-execute which > can be used to specify the capabilities a task should be able to > aquire. > > > Diffs > ----- > > src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa > > Diff: https://reviews.apache.org/r/52741/diff/ > > > Testing > ------- > > * `make check`, including `ROOT` tests, > * tested as root with a `ping` task with an agent where both the task and the > agent have different or no capabilities configured. > > > Thanks, > > Benjamin Bannier > >
