> On Oct. 18, 2016, 12:10 a.m., Jie Yu wrote:
> > src/cli/execute.cpp, line 690
> > <https://reviews.apache.org/r/52741/diff/3/?file=1532680#file1532680line690>
> >
> >     Why the extra `()`?

Misguided consistency with the check above :/ ... I reordered and reformated 
the condition.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52741/#review152969
-----------------------------------------------------------


On Oct. 18, 2016, 9:07 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52741/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 9:07 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5303
>     https://issues.apache.org/jira/browse/MESOS-5303
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces a flags `capabilities` to mesos-execute which
> can be used to specify the capabilities a task should be able to
> aquire.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
> 
> Diff: https://reviews.apache.org/r/52741/diff/
> 
> 
> Testing
> -------
> 
> * `make check`, including `ROOT` tests,
> * tested as root with a `ping` task with an agent where both the task and the 
> agent have different or no capabilities configured.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to