----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51769/#review152348 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp (lines 278 - 281) <https://reviews.apache.org/r/51769/#comment221353> This is not necessary. src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp (lines 283 - 292) <https://reviews.apache.org/r/51769/#comment221355> you can use os::write here. src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp (lines 294 - 295) <https://reviews.apache.org/r/51769/#comment221357> hum, this is not safe. If you close the fd here. In Subprocess teardown, it'll try to close the fd again (which might already be allocated to others). - Jie Yu On Sept. 29, 2016, 3:11 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51769/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 3:11 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > Implemented `delegate` method. > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 > > Diff: https://reviews.apache.org/r/51769/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
