-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/
-----------------------------------------------------------

(Updated Oct. 12, 2016, 1:48 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
-------

* Added a guard in `ProcessManager::finalize` to prevent any further `spawn`s.  
This removes the need for logic in `~ProcessManager`.
* Added a bunch of comments for clarification of why some things are done in 
some order.
* Changed `ProcessManager::finalize` to terminated by UPID.
* Changed the order of `Clock::finalize`


Bugs: MESOS-3910
    https://issues.apache.org/jira/browse/MESOS-3910


Repository: mesos


Description
-------

The `SocketManager` and `ProcessManager` are highly inter-dependent, 
which requires some untangling in `process::finalize`.

* Logic originally found in `~ProcessManager` has been split into 
  `ProcessManager::finalize` due to what happens during cleanup.
* The future from `__s__->accept()` must be explicitly discarded as 
  libevent does not detect a locally closed socket.
* Terminating `HttpProxy`s must close the associated socket.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp f1d746c52cfe659f5cd7da4b7a6424ff585619a3 

Diff: https://reviews.apache.org/r/40266/diff/


Testing
-------

`make check` (libev)
`make check` (--enable-libevent --enable-ssl)


Thanks,

Joseph Wu

Reply via email to