-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/
-----------------------------------------------------------
(Updated Sept. 19, 2016, 5:26 p.m.)
Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere,
and Vinod Kone.
Changes
-------
Rename the ProcessManager termination helper function. Revise a bunch of
comments.
Bugs: MESOS-3910
https://issues.apache.org/jira/browse/MESOS-3910
Repository: mesos
Description
-------
The `SocketManager` and `ProcessManager` are highly inter-dependent,
which requires some untangling in `process::finalize`.
* Logic originally found in `~ProcessManager` has been split into
`ProcessManager::finalize` due to what happens during cleanup.
* The future from `__s__->accept()` must be explicitly discarded as
libevent does not detect a locally closed socket.
* Terminating `HttpProxy`s must close the associated socket.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp a6fbf92bd6d69d94490b9faf4960f14aa112e8d2
Diff: https://reviews.apache.org/r/40266/diff/
Testing
-------
`make check` (libev)
`make check` (--enable-libevent --enable-ssl)
Thanks,
Joseph Wu
