-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52311/#review152438
-----------------------------------------------------------




src/slave/slave.cpp (line 4219)
<https://reviews.apache.org/r/52311/#comment221452>

    You don't need this `if` statement here, since you check this boolean in 
each place below.



src/slave/slave.cpp (line 4230)
<https://reviews.apache.org/r/52311/#comment221453>

    flags.switch_user && !customExecutor.command().has_user()


- Joseph Wu


On Oct. 11, 2016, 11:50 a.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52311/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2016, 11:50 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass the user value from executor of switch_user flag is set.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 
> 
> Diff: https://reviews.apache.org/r/52311/diff/
> 
> 
> Testing
> -------
> 
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether 
> the logs are getting rotated. 
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs 
> are getting rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>

Reply via email to