-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52311/#review153013
-----------------------------------------------------------



The `MasterTest.MasterFailoverLongLivedExecutor` failing indicates a regression 
with this patch.  Since we can't change the `getExecutorInfo` method without 
breaking something else, we'll have to resort to making a change to the 
`ContainerLogger`'s interface.  It will need an explicit `const Option<string>& 
user` argument.

In the Mesos containerizer, that user can be derived like:
```
Option<string> user;
if (container->config.has_user()) {
  user = container->config.user();
}
```

In the Docker containerizer, it is simply:
```
container->user
```

- Joseph Wu


On Oct. 13, 2016, 11:52 a.m., Sivaram Kannan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52311/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 11:52 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
>     https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Pass the user value from executor of switch_user flag is set.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 
> 
> Diff: https://reviews.apache.org/r/52311/diff/
> 
> 
> Testing
> -------
> 
> 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether 
> the logs are getting rotated. 
> 2. Run the mesos-logrotate-logger as root user and verify whether the logs 
> are getting rotated.
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>

Reply via email to