> On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp, line 55 > > <https://reviews.apache.org/r/45963/diff/15/?file=1511373#file1511373line55> > > > > If you end up removing the check for persistent volumes in this > > function per Yan's comment, then perhaps we could also add a comment here > > saying that the function assumes that its input is a persistent volume. > > Renaming the resource parameter to `persistentVolume` could help make this > > clear as well.
I moved the functionality inline since the resource being looked into is a persistent volume. > On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote: > > src/examples/persistent_shared_volume_framework.cpp, line 191 > > <https://reviews.apache.org/r/45963/diff/15/?file=1511368#file1511368line191> > > > > s/used/uses/ > > Greg Mann wrote: > It looks like this typo is still present? Or perhaps you meant to drop > the issue instead of resolve? Will fix in https://reviews.apache.org/r/45962 when I update that. Please feel free to add that comment in https://reviews.apache.org/r/45962 so that it is not forgotten. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review151731 ----------------------------------------------------------- On Oct. 13, 2016, 5:24 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45963/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 5:24 a.m.) > > > Review request for mesos, Greg Mann and Jiang Yan Xu. > > > Bugs: MESOS-4324 > https://issues.apache.org/jira/browse/MESOS-4324 > > > Repository: mesos > > > Description > ------- > > Allow the task to specify the persistent volume access to be read-only > or read-write. Note that the persistent volume is always created as > read-write. > If the task is the first consumer of the shared persistent volume, then > set the ownership of the persistent volume to match that of the task. > Otherwise, launch the task but if the task is unable to read/write the > persistent volume, it would fail at that point of time. > > > Diffs > ----- > > src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d > src/slave/containerizer/docker.cpp d71386089bf7677872bcb1bd36e07da9263dcf0d > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 8f62162519f12a157c28ca5f2a76502e466c1481 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > af427c6e5691f1770ab3ebef79502eb2c2176c4a > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > eb191a32381f9d1ca84ec29adf352dde375c2f2d > src/tests/master_validation_tests.cpp > 99e350e0587e73e9ee25ef20dd369cd146bd446a > > Diff: https://reviews.apache.org/r/45963/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
