----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review152636 -----------------------------------------------------------
Ship it! Committing with minor edits. src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 730) <https://reviews.apache.org/r/45963/#comment221740> Keep the logging? src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lines 254 - 257) <https://reviews.apache.org/r/45963/#comment221741> Part of this paragraph is already said by the log line so I've simplified it into: ``` // NOTE: We cannot enforce read-only access given the symlink without // changing the source so we just log a warning here. ``` - Jiang Yan Xu On Oct. 13, 2016, 8:23 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45963/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 8:23 p.m.) > > > Review request for mesos, Greg Mann and Jiang Yan Xu. > > > Bugs: MESOS-4324 > https://issues.apache.org/jira/browse/MESOS-4324 > > > Repository: mesos > > > Description > ------- > > Allow the task to specify the persistent volume access to be read-only > or read-write. Note that the persistent volume is always created as > read-write. > If the task is the first consumer of the shared persistent volume, then > set the ownership of the persistent volume to match that of the task. > Otherwise, launch the task but if the task is unable to read/write the > persistent volume, it would fail at that point of time. > > > Diffs > ----- > > src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d > src/slave/containerizer/docker.cpp 9a1a8712bf4aba27927136b3a61beaca1b1af997 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 8f62162519f12a157c28ca5f2a76502e466c1481 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > af427c6e5691f1770ab3ebef79502eb2c2176c4a > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > eb191a32381f9d1ca84ec29adf352dde375c2f2d > src/tests/master_validation_tests.cpp > 99e350e0587e73e9ee25ef20dd369cd146bd446a > > Diff: https://reviews.apache.org/r/45963/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
