-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49829/#review152760
-----------------------------------------------------------




src/uri/fetcher.hpp (line 43)
<https://reviews.apache.org/r/49829/#comment221854>

    Looks like an unintentional indent.


- Michael Park


On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49829/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 2:58 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order for different `Flags` classes to be composable classes should
> always use virtual inheritance.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa 
>   src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f 
>   src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
>   src/examples/disk_full_framework.cpp 
> 1221f83d495f7c1ee1bcbcfe067e303db0a921eb 
>   src/examples/load_generator_framework.cpp 
> 5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
>   src/examples/long_lived_framework.cpp 
> 7c57eb5e4a34208504475013690ae8e3cae74155 
>   src/examples/no_executor_framework.cpp 
> 57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
>   src/examples/persistent_volume_framework.cpp 
> 3cc7cf0c4c97d90f2e70800d7a8d4ca64c2150d1 
>   src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 
>   src/local/flags.hpp c77eff13e7a63630ff6c9428e57f3f6707e1f30f 
>   src/log/tool/benchmark.hpp e905e85301df089e3a260bff8e51c6aae574bd46 
>   src/log/tool/initialize.hpp 33d2c5c4e54cbdad30cb3102f36340b1cac3bc67 
>   src/log/tool/read.hpp 7ec82759efc90385ea3d1bc36bdc8ddb95dfa489 
>   src/log/tool/replica.hpp 9ca92ae1736a15b88a386cdf9f08c35253065fe5 
>   src/master/flags.hpp 708a629dab39e8cf161b0dd43420fcd761044102 
>   src/sched/flags.hpp 8782c7bef833cbf418a60a0d296352f1cbe63d7b 
>   src/scheduler/flags.hpp 6d0e95ed375726f8ab203e5fb40ef5bd299004e5 
>   src/slave/container_loggers/lib_logrotate.hpp 
> a8653d716a898f03cce83f7b88b666dc46c0ea90 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 70f30831819d7a0e6233fcb13a703dc6981324b6 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 
> e852c46a5027c7c911bb7f0c9364ff830f4df086 
>   src/slave/containerizer/mesos/launch.hpp 
> a9b6ee2f0da2c1c84c6a0642adbce20a9f0218dc 
>   src/slave/containerizer/mesos/mount.hpp 
> fcfe8601886e4f93386f71931a514ea7f44f19d3 
>   src/slave/flags.hpp 3952d04f6a00ac1dca1adf2bea7cc6e415620ce5 
>   src/tests/active_user_test_helper.hpp 
> b99d1e40acc65821b85c24cc4ac6f34c97678f9a 
>   src/tests/containerizer/capabilities_test_helper.hpp 
> 256ee3b5a986a5c59da7f479a64c63e02884adcb 
>   src/tests/flags.hpp 3066399152bf0e152f6876e001af65d4e945fb8f 
>   src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
> 
> Diff: https://reviews.apache.org/r/49829/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to