-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52771/#review152988
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1231)
<https://reviews.apache.org/r/52771/#comment222194>

    Just to be consistent with `output` above, let's use `error` here.



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1507 - 1508)
<https://reviews.apache.org/r/52771/#comment222195>

    Looks like CNI spec does not specify if stdout will be empty or not. Let's 
just print all of them like you did in the attach code.


- Jie Yu


On Oct. 12, 2016, 6:27 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52771/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 6:27 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6282
>     https://issues.apache.org/jira/browse/MESOS-6282
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Till now we were capturing only the `stdout` of the CNI plugin. However,
> during errors it makes sense to add the output from `stderr` for the
> CNI plugin as well, since as per the CNI spec the CNI plugin is
> supposed to output all unstructured output (debugs for example) to
> `stderr`. This greatly helps in debugging the exact reason for CNI
> plugin failures.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 70f30831819d7a0e6233fcb13a703dc6981324b6 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1b22b28825e8160f659c3cbac37cc576f01666d5 
> 
> Diff: https://reviews.apache.org/r/52771/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to