----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/#review153004 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1229) <https://reviews.apache.org/r/52771/#comment222213> Why this change? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1486 - 1487) <https://reviews.apache.org/r/52771/#comment222214> Out of date? - Jie Yu On Oct. 18, 2016, 12:02 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52771/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 12:02 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6282 > https://issues.apache.org/jira/browse/MESOS-6282 > > > Repository: mesos > > > Description > ------- > > Till now we were capturing only the `stdout` of the CNI plugin. However, > during errors it makes sense to add the output from `stderr` for the > CNI plugin as well, since as per the CNI spec the CNI plugin is > supposed to output all unstructured output (debugs for example) to > `stderr`. This greatly helps in debugging the exact reason for CNI > plugin failures. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 70f30831819d7a0e6233fcb13a703dc6981324b6 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 7c35c3056326a8a135e4ad944ac741cda96cab99 > > Diff: https://reviews.apache.org/r/52771/diff/ > > > Testing > ------- > > make and make check. > > > Thanks, > > Avinash sridharan > >
