> On Oct. 18, 2016, 7:58 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/mkdir.hpp, line 43 > > <https://reviews.apache.org/r/52980/diff/1/?file=1540377#file1540377line43> > > > > Permissions is a bit of a subtle issue in Mesos, which we've largely > > punted on. I'm a bit worried that adding a pluggable `mode` here will cause > > us to add code that only works on Unix. How do you see this API evolving to > > accommodate both? > > Alex Clemmer wrote: > Also, sorry, I should have been more clear: I mean that permissions _on > Windows_ is a subtle issue in Mesos. My worry is rooted in the fact that this > API also has to support Windows.
So, er either extend `mkdir()` to include a `mode` (which as you indicated would need a change in the windows api also), OR call `chmod()` recursively after the call to the existing `mkdir()` [ie. without `mode`]. Currently, linux implementation in stout does not have a recursive `chmod()` which needs to be added, and I think windows just punts on `chmod()` calls. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52980/#review153155 ----------------------------------------------------------- On Oct. 18, 2016, 7:43 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52980/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 7:43 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4893 > https://issues.apache.org/jira/browse/MESOS-4893 > > > Repository: mesos > > > Description > ------- > > Mode still defaults to 755, but we now enable the caller to specify > a different mode for creation of directories. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/mkdir.hpp > fe86864c8b480993c8f052f39b2fd3ece23798da > > Diff: https://reviews.apache.org/r/52980/diff/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Anindya Sinha > >
