----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/#review153167 -----------------------------------------------------------
src/tests/api_tests.cpp (line 838) <https://reviews.apache.org/r/52976/#comment222449> Can you use `using mesos::internal::evolve` in the beginning? src/tests/executor_http_api_tests.cpp (line 362) <https://reviews.apache.org/r/52976/#comment222450> Can we get rid of `mesos::` here? src/tests/fault_tolerance_tests.cpp (line 720) <https://reviews.apache.org/r/52976/#comment222451> Can you use `using mesos::internal::scheduler::DEFAULT_REGISTRATION_BACKOFF_FACTOR` in the begining? src/tests/master_contender_detector_tests.cpp (lines 94 - 96) <https://reviews.apache.org/r/52976/#comment222453> Can you do `using mesos::internal::protobuf::createMasterInfo`? src/tests/mesos.hpp (lines 338 - 339) <https://reviews.apache.org/r/52976/#comment222456> Can you add a TODO here to eventually clean this up? src/tests/mesos.hpp (lines 450 - 459) <https://reviews.apache.org/r/52976/#comment222458> Remove this as no one is using thsi. src/tests/mesos.hpp (line 489) <https://reviews.apache.org/r/52976/#comment222461> Can you do ``` #define EXECUTOR_EXECUTOR_INFO createExecutorInfo("default", "exit 1"); ``` src/tests/mesos.hpp (line 502) <https://reviews.apache.org/r/52976/#comment222457> Let's remove this one as no one is using this. src/tests/mesos.hpp (line 509) <https://reviews.apache.org/r/52976/#comment222464> Why static? Should be inline as this is header? src/tests/mesos.hpp (line 623) <https://reviews.apache.org/r/52976/#comment222465> I don't get this. src/tests/mesos.hpp (line 1898) <https://reviews.apache.org/r/52976/#comment222468> 2 lines apart? src/tests/mesos.hpp (lines 1973 - 1975) <https://reviews.apache.org/r/52976/#comment222470> Do you want to change that? - Jie Yu On Oct. 18, 2016, 8:13 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52976/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 8:13 p.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Split mesos test helpers into 'internal' and 'v1' namespaces. > > > Diffs > ----- > > src/tests/api_tests.cpp f0bafd1d5207a687ca0489b05ed1acdc2a6d875d > src/tests/containerizer.hpp 940c4146f4e854a6b1b9ccaba5687e76d5723cba > src/tests/containerizer.cpp 27c29b40f3241807fb22b27f0d9ca64b3e602a8f > src/tests/executor_http_api_tests.cpp > a9f1a7b0498acd541c6f58ad1388da49c9951e22 > src/tests/fault_tolerance_tests.cpp > 5a9944cf459ab688907d95bbda09f464b37efd1e > src/tests/http_fault_tolerance_tests.cpp > 57ef562058f8abf9256e2ab8a4a85b36b5a7add4 > src/tests/master_contender_detector_tests.cpp > 2a7d713f74c907235f82d83eaf46630046645faf > src/tests/master_maintenance_tests.cpp > 6917272f2de7a09bf4de7e932994655f4e54d3da > src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305 > src/tests/mesos.hpp 9309b5a985c0d7136a2ee5aa1598b4fee6194816 > src/tests/scheduler_http_api_tests.cpp > 6390f2eb53d8bb97b98e64ec6e0f795abc3f3c7f > src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 > src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc > > Diff: https://reviews.apache.org/r/52976/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
