----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52976/#review153286 -----------------------------------------------------------
Fix it, then Ship it! Tbanks a ton on this cleanup! src/tests/api_tests.cpp (line 990) <https://reviews.apache.org/r/52976/#comment222563> s/mesos::internal:://? src/tests/api_tests.cpp (line 1057) <https://reviews.apache.org/r/52976/#comment222564> Ditto. src/tests/api_tests.cpp (line 1105) <https://reviews.apache.org/r/52976/#comment222565> Ditto. src/tests/mesos.hpp (lines 610 - 612) <https://reviews.apache.org/r/52976/#comment222568> I think once you make them inline, this is no longer an issue. I don't see template is needed here. src/tests/mesos.hpp (line 619) <https://reviews.apache.org/r/52976/#comment222567> inline? - Jie Yu On Oct. 19, 2016, 4:50 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52976/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 4:50 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-6407 > https://issues.apache.org/jira/browse/MESOS-6407 > > > Repository: mesos > > > Description > ------- > > Split mesos test helpers into 'internal' and 'v1' namespaces. > > > Diffs > ----- > > src/tests/api_tests.cpp f0bafd1d5207a687ca0489b05ed1acdc2a6d875d > src/tests/containerizer.hpp 940c4146f4e854a6b1b9ccaba5687e76d5723cba > src/tests/containerizer.cpp 27c29b40f3241807fb22b27f0d9ca64b3e602a8f > src/tests/default_executor_tests.cpp > 92e6b9f5fb80811c94632de3bb20c8e6d2e895ff > src/tests/executor_http_api_tests.cpp > a9f1a7b0498acd541c6f58ad1388da49c9951e22 > src/tests/fault_tolerance_tests.cpp > 5a9944cf459ab688907d95bbda09f464b37efd1e > src/tests/http_fault_tolerance_tests.cpp > 57ef562058f8abf9256e2ab8a4a85b36b5a7add4 > src/tests/master_contender_detector_tests.cpp > 2a7d713f74c907235f82d83eaf46630046645faf > src/tests/master_maintenance_tests.cpp > 6917272f2de7a09bf4de7e932994655f4e54d3da > src/tests/master_tests.cpp 88cf1e612ad8186ef2cea161b3a52b0df9517305 > src/tests/mesos.hpp 9309b5a985c0d7136a2ee5aa1598b4fee6194816 > src/tests/scheduler_http_api_tests.cpp > 6390f2eb53d8bb97b98e64ec6e0f795abc3f3c7f > src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 > src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 > src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc > > Diff: https://reviews.apache.org/r/52976/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
