----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153384 -----------------------------------------------------------
src/slave/containerizer/docker.hpp (lines 259 - 260) <https://reviews.apache.org/r/50841/#comment222671> This helper will not be called on non linux platform. ``` // Allocate GPU resources for a specified container on Linux. ``` src/slave/containerizer/docker.hpp (lines 269 - 270) <https://reviews.apache.org/r/50841/#comment222672> This helper will not be called on non linux platform. ``` // Deallocate GPU resources for a specified container on Linux. ``` src/slave/containerizer/docker.hpp (line 506) <https://reviews.apache.org/r/50841/#comment222673> s/GPU/GPU resources src/slave/containerizer/docker.cpp (lines 661 - 662) <https://reviews.apache.org/r/50841/#comment222674> kill this, we already have comments for this helper in the header file. Also this will not be called on non-linux platform. src/slave/containerizer/docker.cpp (line 665) <https://reviews.apache.org/r/50841/#comment222675> s/NvidiaGpuAllocator/NvidiaComponents src/slave/containerizer/docker.cpp (lines 685 - 686) <https://reviews.apache.org/r/50841/#comment222676> kill this, we already have comments for this helper in the header file. Also this will not be called on non-linux platform. src/slave/containerizer/docker.cpp (lines 704 - 705) <https://reviews.apache.org/r/50841/#comment222677> kill this, we already have comments for this helper in the header file. Also this will not be called on non-linux platform. src/slave/containerizer/docker.cpp (lines 2151 - 2155) <https://reviews.apache.org/r/50841/#comment222683> Do you have a patch for removing this comment? src/slave/containerizer/docker.cpp (lines 2156 - 2166) <https://reviews.apache.org/r/50841/#comment222681> What about the following: ``` string failure = "Failed to kill the Docker container: " + (kill.isFailed() ? kill.failure() : "discarded future"); #ifdef __linux__ if (!container->gpus.empty()) { failure += ", " + stringify(container->gpus.size()) + " GPUs leaked"; } #endif // __linux__ container->termination.fail(failure); ``` src/slave/containerizer/docker.cpp (line 2210) <https://reviews.apache.org/r/50841/#comment222682> s/GPUs/GPU resources It is better to make the concept consistent by using `GPU resources` for all of the comments. - Guangya Liu On 十月 20, 2016, 10 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50841/ > ----------------------------------------------------------- > > (Updated 十月 20, 2016, 10 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added control logic to allocate/deallocate GPUs to GPU-related task > when the task is started/terminated. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50841/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
