----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153506 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/slave/containerizer/docker.hpp (lines 259 - 260) <https://reviews.apache.org/r/50841/#comment222883> I think that you can simplify the comments directly as ``` // Allocate GPU resources for a specified container. ``` As you aready have those helper functions protected by `#ifdef __linux__`. src/slave/containerizer/docker.hpp (lines 269 - 270) <https://reviews.apache.org/r/50841/#comment222884> ``` // Deallocate GPU resources for a specified container. ``` src/slave/containerizer/docker.cpp (line 702) <https://reviews.apache.org/r/50841/#comment222887> s/NvidiaGpuAllocator/NvidiaComponents src/slave/containerizer/docker.cpp (line 1370) <https://reviews.apache.org/r/50841/#comment222885> kill this - Guangya Liu On 十月 21, 2016, 6:28 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50841/ > ----------------------------------------------------------- > > (Updated 十月 21, 2016, 6:28 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added control logic to allocate/deallocate GPUs to GPU-related task > when the task is started/terminated. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50841/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
