> On Oct. 18, 2016, 3:15 a.m., James Peach wrote: > > 3rdparty/stout/Makefile.am, line 27 > > <https://reviews.apache.org/r/52696/diff/2/?file=1529825#file1529825line27> > > > > Where does ``VARIANTS`` come from?
I need to fix this. I wrongly thought VARIANTS was something that was set elsewhere. I'll apply the appropriate flags in another way. Ideally this was supposed to apply -fPIC and -fPIE only to shared libs. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review153025 ----------------------------------------------------------- On Oct. 21, 2016, 6:29 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52696/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 6:29 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > stout. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am fda069d > > Diff: https://reviews.apache.org/r/52696/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
