----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ -----------------------------------------------------------
(Updated Oct. 25, 2016, 6:19 p.m.) Review request for mesos and Jiang Yan Xu. Changes ------- Addressed review comments. Bugs: MESOS-6062 https://issues.apache.org/jira/browse/MESOS-6062 Repository: mesos Description (updated) ------- When static resources indicate resources with a positive size, we use that for the resources on the agent. However, --resources can include resources with no size, which indicates that mesos agent determine the size of those resources from the agent and uses that information. With this change, JSON or textual representation for disk resources that do not specify any value would not result in an error, but those resources will not be accounted for until a valid size is determined for such resources. A scalar value of -1 in JSON or textual formats still results in an invalid resource. Diffs (updated) ----- include/mesos/resources.hpp f569c931ff7db8d51dfd7c96f4f2addab05df85d include/mesos/v1/resources.hpp f60ab794a0c7c24885c49cc47b798c363e3279e7 src/common/resources.cpp 4bb9beffcb3509f4226b4985e05eccec01412d0f src/slave/containerizer/containerizer.cpp d46882baa904fd439bffb23c324828b777228f1c src/slave/containerizer/mesos/isolators/gpu/allocator.hpp b2eabfebef99ccebef427d144bb816adc0175ecf src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 2e722691475c84afae14009014ea70cc0fdd0e65 src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 Diff: https://reviews.apache.org/r/51879/diff/ Testing ------- Tests passed. Thanks, Anindya Sinha