----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review153814 -----------------------------------------------------------
src/webui/master/static/js/controllers.js (line 401) <https://reviews.apache.org/r/53172/#comment223275> So `pollMetrics` makes the request directly to the leading master whereas `pollState` depends on the fact that `/state` sends a redirect. Can we make the behavior of `pollState` consistent with `pollMetrics`? Also, what's the regression in 1.0 that caused this behavior? Can you add that to the description or the ticket? Otherwise LGTM. - Vinod Kone On Oct. 25, 2016, 6:30 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53172/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 6:30 p.m.) > > > Review request for mesos, Joseph Wu, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6446 > https://issues.apache.org/jira/browse/MESOS-6446 > > > Repository: mesos > > > Description > ------- > > Fixed the broken metrics information of master in WebUI. > > > Diffs > ----- > > src/master/http.cpp 05d29906a73fb049c085abca05b75ec68c259d26 > src/webui/master/static/js/controllers.js > 3dead4f20e2dbeec8447e22ad287dd6ed2378345 > > Diff: https://reviews.apache.org/r/53172/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
