> On Oct. 25, 2016, 6:51 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 402 > > <https://reviews.apache.org/r/53172/diff/1/?file=1545315#file1545315line402> > > > > So `pollMetrics` makes the request directly to the leading master > > whereas `pollState` depends on the fact that `/state` sends a redirect. Can > > we make the behavior of `pollState` consistent with `pollMetrics`? > > > > Also, what's the regression in 1.0 that caused this behavior? Can you > > add that to the description or the ticket? > > > > Otherwise LGTM.
Got it, let me update. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review153814 ----------------------------------------------------------- On Oct. 25, 2016, 6:52 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53172/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 6:52 p.m.) > > > Review request for mesos, Joseph Wu, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6446 > https://issues.apache.org/jira/browse/MESOS-6446 > > > Repository: mesos > > > Description > ------- > > Fixed the broken metrics information of master in WebUI. > > > Diffs > ----- > > src/master/http.cpp 05d29906a73fb049c085abca05b75ec68c259d26 > src/webui/master/static/js/controllers.js > 3dead4f20e2dbeec8447e22ad287dd6ed2378345 > > Diff: https://reviews.apache.org/r/53172/diff/ > > > Testing > ------- > > ... > > > Test screen record. > >  > > > Thanks, > > haosdent huang > >
