----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/#review154152 -----------------------------------------------------------
Ship it! LGTM! Do you want to file another issue to track adding the test or keep the existing issue open? - Anand Mazumdar On Oct. 28, 2016, 6:23 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53159/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 6:23 p.m.) > > > Review request for mesos, Anand Mazumdar, Gilbert Song, and Jiang Yan Xu. > > > Bugs: MESOS-6461 > https://issues.apache.org/jira/browse/MESOS-6461 > > > Repository: mesos > > > Description > ------- > > The existing test (MasterTest.OrphanTasks) continues to pass after > the change. I will try to write another test that spawns multiple > agents to ensure the duplicate framework ids are not shown. > > > Diffs > ----- > > src/master/http.cpp 716077a23defd84a9fac185c96aa52073718c58d > > Diff: https://reviews.apache.org/r/53159/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
