> On Oct. 28, 2016, 8:47 p.m., Jiang Yan Xu wrote: > > Hey > > > > We now have `mesos::internal::master::Master::Frameworks::recovered` to > > track precisely this right?
yea, we unfortunately cannot rely on it because 0.28.0 agents don't send framework infos to master. i'll send another review to deprecate "unregistered_frameworks" (which contains just the frameworks ids) and add a new "recovered_frameworks" which includes the whole framework info. one of the cases where backwards compatibility makes it messy. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53159/#review154177 ----------------------------------------------------------- On Oct. 28, 2016, 7:22 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53159/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 7:22 p.m.) > > > Review request for mesos, Anand Mazumdar, Gilbert Song, and Jiang Yan Xu. > > > Bugs: MESOS-4973 and MESOS-6461 > https://issues.apache.org/jira/browse/MESOS-4973 > https://issues.apache.org/jira/browse/MESOS-6461 > > > Repository: mesos > > > Description > ------- > > The existing test (MasterTest.OrphanTasks) continues to pass after > the change. I will try to write another test that spawns multiple > agents to ensure the duplicate framework ids are not shown. > > > Diffs > ----- > > src/master/http.cpp 716077a23defd84a9fac185c96aa52073718c58d > > Diff: https://reviews.apache.org/r/53159/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
