----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53267/#review154164 -----------------------------------------------------------
Patch looks great! Reviews applied: [53267] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 28, 2016, 5 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53267/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 5 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar. > > > Bugs: MESOS-6499 > https://issues.apache.org/jira/browse/MESOS-6499 > > > Repository: mesos > > > Description > ------- > > Added log and counter for tracking subscribers. > > > Diffs > ----- > > src/master/master.hpp 87186c6e733a686f96528b1722fda1c287e9c881 > src/master/master.cpp 23ddb995b4ad0fcdb589974308a2e81ececdad31 > src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32 > src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494 > > Diff: https://reviews.apache.org/r/53267/diff/ > > > Testing > ------- > > Ran this on master with a client keeps subscribing and disconnecting. > Observes that gauge gets updated and new log line is printed. > > > Thanks, > > Zhitao Li > >
