> On Oct. 28, 2016, 3:49 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/utils.cpp, lines 92-99 > > <https://reviews.apache.org/r/53161/diff/1/?file=1544883#file1544883line92> > > > > Can you double check if it is safe to remove files while walking the > > fts tree? To be more defensive, i would probably remove them after > > finishing the walk.
I think it is OK to remove files while walking the fts tree, you can take a look at `os::rmdir()` which removes files/directories while walking the fts tree. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53161/#review154050 ----------------------------------------------------------- On Oct. 25, 2016, 11:46 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53161/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 11:46 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > e192f86a1848b373f3aa73d29688a96375cac313 > src/slave/containerizer/mesos/utils.hpp > 178ebf3effac824e4788d7282795c18dc1cb5265 > src/slave/containerizer/mesos/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53161/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
