> On Nov. 1, 2016, 5 p.m., Zhitao Li wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp, lines 341-352 > > <https://reviews.apache.org/r/53161/diff/2/?file=1550695#file1550695line341> > > > > Do we need to worry about previously cached image layers in stores, if > > the `image_provisioner_backend` flag value is changed from something else > > to `overlay`?
Nope, because we use the backend name as the suffix (e.g., `rootfs.overlay`). The content in `rootfs` from the previou layers pulled from docker registry should be in aufs whiteout format. So switching the flag should be safe. The invariant here is that anything under `rootfs.overlay` will be in overlay whiteout format, and anything under `rootfs` should be in aufs whiteout format. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53161/#review154416 ----------------------------------------------------------- On Nov. 1, 2016, 6:42 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53161/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 6:42 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6360 > https://issues.apache.org/jira/browse/MESOS-6360 > > > Repository: mesos > > > Description > ------- > > Implemented the conversion from AUFS whiteouts to OverlayFS whiteouts. > > > Diffs > ----- > > src/Makefile.am c2f9e442182110d0b450d4824600a4a791f8cf27 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > e192f86a1848b373f3aa73d29688a96375cac313 > src/slave/containerizer/mesos/provisioner/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53161/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
