> On Oct. 31, 2016, 10:38 a.m., Benjamin Bannier wrote: > > src/cli/execute.cpp, lines 709-713 > > <https://reviews.apache.org/r/53152/diff/1/?file=1544752#file1544752line709> > > > > What's the order of enumeration here? IMHO we should either stick to > > alphabetical or alternatively the order of parameters to `getContainerInfo`.
We probably needs to refactor the logic here. I just group all images together so it's easy to reason about. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53152/#review154242 ----------------------------------------------------------- On Oct. 24, 2016, 11:06 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53152/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 11:06 p.m.) > > > Review request for mesos, Benjamin Bannier and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > Added rlimit support to mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp e694853441c24cf17d8fd5a2ee1be17337458f67 > > Diff: https://reviews.apache.org/r/53152/diff/ > > > Testing > ------- > > `bin/mesos-execute --master=10.0.49.2:5050 --command="ulimit -a" --name=test > --rlimits='{"rlimits":[{"type":"RLMT_NPROC"}]}'` > > > Thanks, > > Jie Yu > >
