> On Nov. 2, 2016, 4:29 p.m., Till Toenshoff wrote: > > src/health-check/health_checker.cpp, line 77 > > <https://reviews.apache.org/r/51607/diff/3/?file=1549257#file1549257line77> > > > > Some abstraction doing this automagically would be cool to have, no? > > e.g. `Path::runnable(string)` adding ".exe" on Windows.
Created MESOS-6533 for discussing this. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review154569 ----------------------------------------------------------- On Oct. 31, 2016, 6:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51607/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 6:56 p.m.) > > > Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/health-check/health_checker.hpp > 392b4d5bd1e5831994b9366c1eb5a2911e19860f > src/health-check/health_checker.cpp > 96ae1a733ff3d211b84d0893b4603873af1c89f0 > src/launcher/default_executor.cpp f5ff02a63d0b12833dd383378f99ee337a3bcf30 > src/launcher/executor.cpp 0544121e679db503fe4eaf23a24e315eb188a520 > > Diff: https://reviews.apache.org/r/51607/diff/ > > > Testing > ------- > > make check on Mac OS 10.11.6 > > > Thanks, > > Alexander Rukletsov > >
