----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review154738 -----------------------------------------------------------
src/local/flags.hpp (lines 35 - 45) <https://reviews.apache.org/r/52787/#comment224419> I don't think we should have a flag for `temp_dir` here. We should still have separate flags for `work_dir` and `runtime_dir`. With those, you can still organize things similar to what you've described above, but each should be rooted differently, i.e.: ``` /tmp/mesos/work |-- master | |-- replicated_log | | |-- 000004.log | | |-- CURRENT | | |-- LOCK | | |-- LOG | | |-- MANIFEST-000002 |-- agents |-- 0 | |-- meta | | |-- boot_id | | |-- slaves | | |-- 5b7cf084-32d7-4530-8451-d6e5db19f48f-S0 | | | |-- slave.info | | |-- latest -> /tmp/mesos/work/meta/slaves/5b7cf084-32d7-4530-8451-d6e5db19f48f-S0 | |-- provisioner |-- 1 |-- meta | |-- boot_id | |-- slaves | |-- 5b7cf084-32d7-4530-8451-d6e5db19f48f-S1 | | |-- slave.info | |-- latest -> /tmp/mesos/work/meta/slaves/5b7cf084-32d7-4530-8451-d6e5db19f48f-S1 |-- provisioner /tmp/mesos/runtime |-- agents |-- 0 | |-- runtime_dir |-- 1 |-- runtime_dir ``` src/local/local.cpp (line 359) <https://reviews.apache.org/r/52787/#comment224414> s/work_dir/work/ src/local/local.cpp (line 363) <https://reviews.apache.org/r/52787/#comment224413> s/runtime_dir/runtime/ - Kevin Klues On Nov. 2, 2016, 5:14 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52787/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 5:14 p.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6380 > https://issues.apache.org/jira/browse/MESOS-6380 > > > Repository: mesos > > > Description > ------- > > Add a new flag `temp_dir` when running Mesos in local mode. It is the > parent directory to create the work directory and other directories for > master and agents automatically. > > > Diffs > ----- > > bin/mesos-local-flags.sh.in 5b4553a808dc9f34a15390e69b2f85e95761ec53 > src/local/flags.hpp c77eff13e7a63630ff6c9428e57f3f6707e1f30f > src/local/local.cpp 257179443827ffdfc946ed655a6840fcea70d454 > src/tests/dynamic_reservation_framework_test.sh > c094ed1464c61b6acf647549f1fd83117b135358 > src/tests/java_exception_test.sh 9692b2139ece5dd553e6ecde1a3837bed5144b2c > src/tests/java_framework_test.sh c53e4abd75e5ff5d1fa1d1aad7f7d54806f9f899 > src/tests/java_v0_framework_test.sh > 5b602258529c62782d510793a6f992fd7fb6c181 > src/tests/java_v1_framework_test.sh > 63f35d9c240efd3f0acd159f85419881772162a4 > src/tests/no_executor_framework_test.sh > df282cab6e91645d19d0aa09867e6b45adaf2508 > src/tests/persistent_volume_framework_test.sh > 2ab22c03e573d4801c73957f9cad2939b3d3174b > src/tests/python_framework_test.sh 58beb9eb14832ff4cb4d318303a30630a012c38c > src/tests/test_framework_test.sh 8782e01edc5be3833760fc45e2b545fce100547b > src/tests/test_http_framework_test.sh > 256655dfd7697071547f755e8941822b6d51f8a8 > > Diff: https://reviews.apache.org/r/52787/diff/ > > > Testing > ------- > > ``` > $ ./src/mesos-local --num_slaves=2 > > $ tree /tmp/mesos/local > /tmp/mesos/local > |-- agents > | |-- 0 > | | |-- runtime_dir > | | |-- work_dir > | | |-- meta > | | | |-- boot_id > | | | |-- slaves > | | | |-- 5b7cf084-32d7-4530-8451-d6e5db19f48f-S0 > | | | | |-- slave.info > | | | |-- latest -> > /tmp/mesos/local/agents/0/work_dir/meta/slaves/5b7cf084-32d7-4530-8451-d6e5db19f48f-S0 > | | |-- provisioner > | |-- 1 > | |-- runtime_dir > | |-- work_dir > | |-- meta > | | |-- boot_id > | | |-- slaves > | | |-- 5b7cf084-32d7-4530-8451-d6e5db19f48f-S1 > | | | |-- slave.info > | | |-- latest -> > /tmp/mesos/local/agents/1/work_dir/meta/slaves/5b7cf084-32d7-4530-8451-d6e5db19f48f-S1 > | |-- provisioner > |-- master > |-- work_dir > |-- replicated_log > |-- 000004.log > |-- CURRENT > |-- LOCK > |-- LOG > |-- MANIFEST-000002 > > 20 directories, 9 files > ``` > > > ``` > $ ./bin/mesos-local.sh > tree /tmp/mesos/ > /tmp/mesos/ > |-- agents > | |-- 0 > | |-- runtime_dir > | |-- work_dir > | |-- meta > | | |-- boot_id > | | |-- slaves > | | |-- 0e617524-b582-4793-8a47-184c542e95d2-S0 > | | | |-- slave.info > | | |-- latest -> > /tmp/mesos/agents/0/work_dir/meta/slaves/0e617524-b582-4793-8a47-184c542e95d2-S0 > | |-- provisioner > |-- master > |-- work_dir > |-- replicated_log > |-- 000004.log > |-- CURRENT > |-- LOCK > |-- LOG > |-- MANIFEST-000002 > > 12 directories, 7 files > ``` > > > Thanks, > > haosdent huang > >
