----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review155500 -----------------------------------------------------------
bin/mesos-local-flags.sh.in (lines 19 - 20) <https://reviews.apache.org/r/52787/#comment225468> Do we even these anymore since we set the work/runtime dir in the code via e.g.: ``` path::join(os::temp(), "mesos", "work")); ``` It seems better to use `os::temp()` than to hard code `/tmp` - Kevin Klues On Nov. 9, 2016, 4:53 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52787/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 4:53 p.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6380 > https://issues.apache.org/jira/browse/MESOS-6380 > > > Repository: mesos > > > Description > ------- > > Reorganized the work directory and the runtime directory in local mode. > > > Diffs > ----- > > bin/mesos-local-flags.sh.in 5b4553a808dc9f34a15390e69b2f85e95761ec53 > src/local/flags.hpp 3d8e5392f770a72354215829022b677caee9d8c6 > src/local/local.cpp 257179443827ffdfc946ed655a6840fcea70d454 > > Diff: https://reviews.apache.org/r/52787/diff/ > > > Testing > ------- > > No matter use `bin/mesos-local.sh` or use `src/mesos-local`, the folder > structure looks like > > ``` > $ tree /tmp/mesos/ > /tmp/mesos/ > |-- runtime > | |-- agents > | |-- 0 > | |-- 1 > |-- work > |-- agents > | |-- 0 > | | |-- meta > | | | |-- boot_id > | | | |-- slaves > | | | |-- a63fbc0a-268e-4ebe-b31c-90d3a19d2fb3-S0 > | | | | |-- slave.info > | | | |-- latest -> > /tmp/mesos/work/agents/0/meta/slaves/a63fbc0a-268e-4ebe-b31c-90d3a19d2fb3-S0 > | | |-- provisioner > | |-- 1 > | |-- meta > | | |-- boot_id > | | |-- slaves > | | |-- b4d008bc-6be4-4bba-97c3-3a73d3f9611d-S0 > | | | |-- slave.info > | | |-- latest -> > /tmp/mesos/work/agents/1/meta/slaves/b4d008bc-6be4-4bba-97c3-3a73d3f9611d-S0 > | |-- provisioner > |-- master > |-- replicated_log > |-- 000009.log > |-- 000011.sst > |-- CURRENT > |-- LOCK > |-- LOG > |-- LOG.old > |-- MANIFEST-000006 > > 20 directories, 11 files > ``` > > > Thanks, > > haosdent huang > >
