----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53435/#review154904 -----------------------------------------------------------
src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 29 - 30) <https://reviews.apache.org/r/53435/#comment224695> This looks unintentional. src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 32 - 33) <https://reviews.apache.org/r/53435/#comment224696> Add a newline after including `runtime.hpp`. src/tests/containerizer/docker_volume_isolator_tests.cpp (lines 33 - 34) <https://reviews.apache.org/r/53435/#comment224693> I am unsure what style is preferred here. We could (a) order header groups by directory depth (that's e.g., the reason `slave/containerizer/mesos/linux_launcher.hpp` is on l.29, not below l.36, or (b) keep related headers together. I can see both patterns in the code base. Maybe you have an idea. - Benjamin Bannier On Nov. 3, 2016, 5:23 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53435/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 5:23 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed header include order. > > > Diffs > ----- > > src/tests/containerizer/docker_volume_isolator_tests.cpp > ca7bffd3b1773a11a4679d114885d3edd977b02b > src/tests/containerizer/mesos_containerizer_tests.cpp > 4df537747d84daa68c29e2d05b22fa386a4a16db > > Diff: https://reviews.apache.org/r/53435/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
