----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review154979 -----------------------------------------------------------
My `Ship It!` from earlier still stands. Just need to check the remainder of the chain. src/slave/container_loggers/logrotate.cpp (line 246) <https://reviews.apache.org/r/52310/#comment224795> Oops, there's a double-space in the middle of that comment. - Joseph Wu On Nov. 4, 2016, 7:45 a.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52310/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 7:45 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Switch the uid of the binary if a user is passed from the lib_logrotate. > > > Diffs > ----- > > src/slave/container_loggers/logrotate.cpp > 431bc3cbb54e94359078e4dae0b32ad301393640 > > Diff: https://reviews.apache.org/r/52310/diff/ > > > Testing > ------- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
