> On Nov. 4, 2016, 5:40 p.m., Kevin Klues wrote: > > include/mesos/mesos.proto, line 2193 > > <https://reviews.apache.org/r/53464/diff/1/?file=1554131#file1554131line2193> > > > > Why is this the first element in the message? I would think since we > > already have others taht are ordered 1,2,3, we would put this at the bottom > > with 4. > > > > Is it so that we keep the "ContainerID" of the "ContainerStatus" at the > > top? If so, that makes sense to me.
We don't sort according to tag number typically. `id` sounds to me should be logically the first entry. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53464/#review154939 ----------------------------------------------------------- On Nov. 4, 2016, 7:07 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53464/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 7:07 a.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: MESOS-6465 and MESOS-6528 > https://issues.apache.org/jira/browse/MESOS-6465 > https://issues.apache.org/jira/browse/MESOS-6528 > > > Repository: mesos > > > Description > ------- > > Added ContainerID to ContainerStatus. > > > Diffs > ----- > > include/mesos/mesos.proto 905a34bb13c2fcd1b22ef4e9605405ef84711c25 > include/mesos/v1/mesos.proto b72069a6caff0b163d9d9cae45c3caa0b25de38f > src/slave/containerizer/mesos/containerizer.cpp > 67cc595278f124cdf518d2f4fcfb257439f067e2 > src/tests/containerizer/mesos_containerizer_tests.cpp > 4df537747d84daa68c29e2d05b22fa386a4a16db > > Diff: https://reviews.apache.org/r/53464/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
