----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52735/#review155025 -----------------------------------------------------------
Can you make this as the first patch for the patch chain? src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/52735/#comment224853> Instead of killing this directly, can you please update the comments a bit and move it right before #2213 ``` // We've failed to do a Docker::kill, which means that the // container is still running! Here we invoke `Self::remove` // after `docker_remove_delay` to force remove the docker // container again. ``` - Guangya Liu On 十一月 2, 2016, 7:29 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52735/ > ----------------------------------------------------------- > > (Updated 十一月 2, 2016, 7:29 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Repository: mesos > > > Description > ------- > > Removed TODO message for docker killing. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/52735/diff/ > > > Testing > ------- > > > Thanks, > > Yubo Li > >
