> On 十一月 4, 2016, 3:28 p.m., Guangya Liu wrote: > > Seems spliting this to two patches is more simple for review: One patch for > > adding a new flag '--devices' to mesos docker executor, and the other is > > passing 'devices' as parameter for `dockerFlags` when launching mesos > > docker executor.
split to `/r/53533` - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154917 ----------------------------------------------------------- On 十一月 2, 2016, 7:28 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > ----------------------------------------------------------- > > (Updated 十一月 2, 2016, 7:28 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > Also, passed GPUs assignment to mesos-docker-executor. > > > Diffs > ----- > > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
