----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review154379 -----------------------------------------------------------
src/docker/docker.hpp (lines 71 - 96) <https://reviews.apache.org/r/50125/#comment223909> Move this to /r/50599/ , otherwies, /r/50599/ will build failed src/slave/containerizer/docker.cpp (line 234) <https://reviews.apache.org/r/50125/#comment223904> I think that you should not update here but use `Option` as before. src/slave/containerizer/docker.cpp (line 252) <https://reviews.apache.org/r/50125/#comment223907> Here should be ``` if (devices.isSome() && !devices->empty()) { ``` src/slave/containerizer/docker.cpp (line 366) <https://reviews.apache.org/r/50125/#comment223908> Use `None()` directly - Guangya Liu On 十一月 1, 2016, 6:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > ----------------------------------------------------------- > > (Updated 十一月 1, 2016, 6:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > Also, passed GPUs assignment to mesos-docker-executor. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/slave/containerizer/docker.cpp f720320e112687e8ae972f04159b3b4cb7a58476 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
