----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53488/#review155391 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line 39) <https://reviews.apache.org/r/53488/#comment225287> Also, you won't need this after the previous patches are updated to add a `Pipe::Reader::readAll`. 3rdparty/libprocess/src/http.cpp (lines 916 - 918) <https://reviews.apache.org/r/53488/#comment225285> Before you commit this, can you make sure that this looks consistent with the request conversion function in your previous review? Also, this currently copies the response (twice), is it possible to avoid this, much like we did in your previous review? 3rdparty/libprocess/src/http.cpp (line 925) <https://reviews.apache.org/r/53488/#comment225286> Don't forget that this will become `reader.readAll ()` after updating the previous patches, right? - Benjamin Mahler On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53488/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 5:55 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6466 > https://issues.apache.org/jira/browse/MESOS-6466 > > > Repository: mesos > > > Description > ------- > > Removed `convert()` continuations in favor of using `io::read()`. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp b5ddac9f1970358f8232a481431507242052d294 > > Diff: https://reviews.apache.org/r/53488/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
