> On Nov. 9, 2016, 1:16 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, lines 926-928 > > <https://reviews.apache.org/r/53488/diff/1/?file=1554497#file1554497line926> > > > > Before you commit this, can you make sure that this looks consistent > > with the request conversion function in your previous review? > > > > Also, this currently copies the response (twice), is it possible to > > avoid this, much like we did in your previous review?
As discussed offline, this would need a bit more work to argue around lifetime issues of the `Response` object. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53488/#review155391 ----------------------------------------------------------- On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53488/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 5:55 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6466 > https://issues.apache.org/jira/browse/MESOS-6466 > > > Repository: mesos > > > Description > ------- > > Removed `convert()` continuations in favor of using `io::read()`. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp b5ddac9f1970358f8232a481431507242052d294 > > Diff: https://reviews.apache.org/r/53488/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
