----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52919/#review155497 -----------------------------------------------------------
Ship it! I would update the description with a bit more detail about the actual change that was made. Also, the summary line is a little hard to understand. I'd say something like: `Updated scripts to allow override of MESOS environment variables.` - Kevin Klues On Nov. 9, 2016, 4:51 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52919/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 4:51 p.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, and Vinod Kone. > > > Bugs: MESOS-6399 > https://issues.apache.org/jira/browse/MESOS-6399 > > > Repository: mesos > > > Description > ------- > > Allowed to pass extra envs when launch development scripts. > > > Diffs > ----- > > bin/mesos-agent-flags.sh.in 8c936aa06e994a87a8b09b31c907868bf9be38c7 > bin/mesos-local-flags.sh.in 5b4553a808dc9f34a15390e69b2f85e95761ec53 > bin/mesos-master-flags.sh.in 951c3e4c714809bcf2364eb28974aeefb7884bcb > > Diff: https://reviews.apache.org/r/52919/diff/ > > > Testing > ------- > > ``` > $ MESOS_TEMP_DIR=/tmp/mesos/bar ./bin/mesos-local.sh > > $ tree /tmp/mesos/ > /tmp/mesos/ > ??? bar > ??? agents > ? ??? 0 > ? ??? runtime_dir > ? ??? work_dir > ? ??? meta > ? ? ??? boot_id > ? ? ??? slaves > ? ? ??? 6b4ce717-dd6e-4d8c-9f89-66a42e3866a8-S0 > ? ? ? ??? slave.info > ? ? ??? latest -> > /tmp/mesos/bar/agents/0/work_dir/meta/slaves/6b4ce717-dd6e-4d8c-9f89-66a42e3866a8-S0 > ? ??? provisioner > ??? master > ??? work_dir > ??? replicated_log > ??? 000004.log > ??? CURRENT > ??? LOCK > ??? LOG > ??? MANIFEST-000002 > > 13 directories, 7 files > ``` > > > Thanks, > > haosdent huang > >
