> On Oct. 21, 2016, 7:35 p.m., Benjamin Mahler wrote: > > src/health-check/health_checker.cpp, line 188 > > <https://reviews.apache.org/r/52866/diff/1/?file=1537871#file1537871line188> > > > > Isn't this going to lead to some slightly confusing logging where we > > say "Rescheduling" for the first health check?
``` I1111 15:07:43.066488 1601536 health_checker.cpp:193] Health check starting in 0ns, grace period 0ns I1111 15:07:43.066573 1601536 health_checker.cpp:618] Rescheduling health check in 0ns W1111 15:07:43.158612 3747840 health_checker.cpp:215] Health check failed 1 times consecutively: COMMAND health check failed: Command returned exited with status 1 I1111 15:07:43.158704 3747840 health_checker.cpp:618] Rescheduling health check in 0ns ``` I don't think it is very confusing, but if you have a strong opinion, I'll change that. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/#review153584 ----------------------------------------------------------- On Oct. 14, 2016, 12:38 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52866/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 12:38 p.m.) > > > Review request for mesos, Gastón Kleiman and haosdent huang. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/health-check/health_checker.hpp > 392b4d5bd1e5831994b9366c1eb5a2911e19860f > src/health-check/health_checker.cpp > 96ae1a733ff3d211b84d0893b4603873af1c89f0 > > Diff: https://reviews.apache.org/r/52866/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
