> On Nov. 10, 2016, 10:18 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 299 > > <https://reviews.apache.org/r/53624/diff/2/?file=1560612#file1560612line299> > > > > thinking a bit more, this flag should be "content_type" with "protobuf" > > as default. that way if we support more content types in the future, this > > would be future proof.
Added command flag ... does that look like what you had in mind? - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53624/#review155657 ----------------------------------------------------------- On Nov. 11, 2016, 12:49 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53624/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 12:49 a.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6562 > https://issues.apache.org/jira/browse/MESOS-6562 > > > Repository: mesos > > > Description > ------- > > Using the JSON content type in mesos-execute makes packet tracing > protocol interactions easier. Add a --content_type option that > switched between protobuf (the default) and JSON content types. > > > Diffs > ----- > > src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 > > Diff: https://reviews.apache.org/r/53624/diff/ > > > Testing > ------- > > make check. Manually verified with tcpdump. > > > Thanks, > > James Peach > >
